Open
Conversation
Author
|
SamTheKorean
reviewed
Mar 1, 2026
Contributor
There was a problem hiding this comment.
worst case 시간 복잡도에 대해서 생각해본적이 없었는데 리뷰하면서 공부할 기회가 되었습니다!
SamTheKorean
reviewed
Mar 1, 2026
| // This solution was inspired by: | ||
| // https://www.algodale.com/problems/longest-consecutive-sequence/ | ||
| // | ||
| // I initially believed this algorithm would run in O(n) time, |
Contributor
There was a problem hiding this comment.
사고흐름을 상세하게 기술해놓는 것 정말 좋은 것 같습니다!
SamTheKorean
approved these changes
Mar 1, 2026
Contributor
SamTheKorean
left a comment
SamTheKorean
left a comment
There was a problem hiding this comment.
다섯 문제나 정말 상세하게 정리해주셔서 리뷰하면서 저도 공부가 되는 부분이 많았습니다! 고생많으셨습니다!
|
|
||
| // The Set has O(n) space complexity, | ||
| // because it may store up to n elements in memory. | ||
| // Is this the correct way to evaluate space complexity? |
Contributor
There was a problem hiding this comment.
넵! 지금 분석하신 것처럼 주어진 것에서 추가적으로 사용된 공간에 대해서 분석하시면 됩니다!
| class Solution { | ||
| public int[] twoSum(int[] nums, int target) { | ||
| // Approach : using HashMap to get index with the element in O(n) time | ||
| // complexity |
Contributor
There was a problem hiding this comment.
nitpick : 이부분은 time complexity 라고 명시해주는게 정확할 것 같습니다!
Author
There was a problem hiding this comment.
넵 줄바꿈이 조금 이상하게 적용되어있네요
해당부분도 신경써보겠습니다
감사합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!